fritz-marshal / fritz

Astronomical data platform for the Zwicky Transient Facility.
https://fritz.science
Other
24 stars 34 forks source link

Wrong time axis on Liverpool Telescope observability plots #490

Closed JTerwel closed 1 year ago

JTerwel commented 1 year ago

Description The observability plot for the Liverpool Telescope lists the wrong times

To Reproduce Steps to reproduce the behavior:

  1. Go to https://fritz.science/observability/ZTF22abqxkhd or another object
  2. Select Liverpool Telescope & Nordic Optical Telescope
  3. Note the differing x-axis while the rest is the same

Expected behavior As the Liverpool Telescope & Nordic Optical Telescope are both on Roque de los Muchachos de La Palma, both plots should be the same. As the sun does not set at 5PM in this time of the year (mid November), it is the Liverpool Telescope whose x-axis is off. Below is a screenshot with an example.

Screenshot 2022-11-17 at 14 00 54

Platform information:

mcoughlin commented 1 year ago

@JTerwel It looks like LT was put in the wrong place originally. https://fritz.science/telescopes Maybe you @JTerwel or Dan could use the patch API to change the latitude and longitude?

JTerwel commented 1 year ago

Sorry, I'm not sure how to do that unfortunately.

But from looking at the telescope placements, the WHT and INT have the same issue: a minus sign is missing in the longitude.

mcoughlin commented 1 year ago

@JTerwel https://www.youtube.com/watch?v=3qnCT0orKiI&list=PLCRsMmFfImh3SJJOEU8SI2sWrKbV6BnDJ&index=7&ab_channel=SkyPortalAstronomy

The telescope PUT API is here: https://github.com/skyportal/skyportal/blob/main/skyportal/handlers/api/telescope.py#L221

and the example is here: https://github.com/skyportal/skyportal/blob/main/skyportal/tests/api/test_telescope.py#L132

JTerwel commented 1 year ago

I have tried to change the longitude, but keep getting an authorisation error. What ACL should my token have to be able to do this?

I have Annotate, Classify, Comment, and Upload data. I can make another with Manage observing runs and Run Analyses, but none of these, but I'd have to delete my current one first so I'd like to confirm if this would solve the authorisation access issue first.

mcoughlin commented 1 year ago

@JTerwel Please reach out to me on slack to resolve permissions.

JTerwel commented 1 year ago

Issue has been fixed. The LT, INT, and WHT are all in their correct location on La Palma