fritzing / fritzing-app

Fritzing desktop application
http://fritzing.org
Other
4.02k stars 830 forks source link

Eagle lbr importer #1941

Closed davidperrenoud closed 10 years ago

davidperrenoud commented 10 years ago

From andre.knoerig@gmail.com on April 10, 2012 13:54:37

It's already working very well, here are some suggestions for improvement:

DIP & DIL ICs:

SMD ICs:

GENERAL:

CONNECTORS: In order to distinguish the connectors which should be treated separately (in the generator) we can pick the ones that have a part title of "Header 1" etc. or family "m01", "m02", "m05x2" etc. A few exceptions need to be included: PINH2X12, PIN HEADER, PINHD-2X26 -> I already manually updated the table to reflect this.

A package name of "1x06" etc. is not a reason to treat these parts separately as generated connectors. It just tells us what the breadboard graphic should look like:

package name > graphics

1x06-... > male pin headers, vertical molex-... > molex vertical jst-... > jst right angled screwterminal-... > screw terminal

Original issue: http://code.google.com/p/fritzing/issues/detail?id=1941

davidperrenoud commented 10 years ago

From irasc...@gmail.com on April 16, 2012 04:54:23

are there any parts on the wishlist we should add to this? http://fritzing.org/about/roadmap/parts-plan/ Are there other open source lbr files we should include?

davidperrenoud commented 10 years ago

From irasc...@gmail.com on April 16, 2012 04:58:26

chip labels: this will probably have to be handled by making these generative in Fritzing.

schematic pin labels: easy enough for rectangular schematics (the trick will be to figure out which ones are rectangular), no idea what to do for other cases. This may also have to be handled by the Fritzing app.

davidperrenoud commented 10 years ago

From irasc...@gmail.com on April 16, 2012 05:06:16

Labels: Milestone-0.7.5

davidperrenoud commented 10 years ago

From irasc...@gmail.com on April 17, 2012 04:33:55

I do not think the lt19014, max6675, and attiny24 (and others like them) can be fixed automatically because they are underspecified in the xml. Since the max6675 has the least number of pins of the three parts, I will use that for an example, but all three have a similar issue.

The max6675 uses the so08 package, so there are indeed 8 pins in the footprint. However, both the schematic xml and "device" xml only specify 7. I don't see any way to recover information about what the 8th pin is doing. The schematic defines 7 pins:

VSS, T-, T+, VDD, MISO, CS, SCK

the "device" links these to 7 pads (in order):

1, 2, 3, 4, 7, 6, 5


Aside from this, I see a bug that though the right number is associated with the right name on the generated parts, these are not in the correct physical position on the chip in breadboard and pcb view.

davidperrenoud commented 10 years ago

From irasc...@gmail.com on May 21, 2012 03:33:24

Labels: -Priority-High Priority-Critical

davidperrenoud commented 10 years ago

From irasc...@gmail.com on May 21, 2012 03:36:07

reposting Andre's comment from issue #921 :

After the SparkFun library, we could also include these:

Adafuit - http://www.ladyada.net/library/pcb/eaglelibrary.html Seeed Studio - https://github.com/Seeed-Studio/EagleLib-of-Seeedstudio Dangerous Prototypes - http://dangerousprototypes.com/docs/Dangerous_Prototypes_Cadsoft_Eagle_parts_library

davidperrenoud commented 10 years ago

From irasc...@gmail.com on May 23, 2012 05:13:31

r5994 : schematics include pin names. They look decent in a surprisingly large percentage of cases, but there is some hand_tweaking or programmatic nudging required. I wonder whether to add this to the googledoc, or make a separate xml params doc.

davidperrenoud commented 10 years ago

From irasc...@gmail.com on May 23, 2012 06:17:40

Back to the aside in comment 4: in pcb view, the connector name is positioned correctly, but the connector number is wrong. In breadboard view, the connector number is positioned correctly, but the name is wrong. I think this is because the index number of the connectors is generated when they are encountered in and , rather than using the pad number specified in .

davidperrenoud commented 10 years ago

From irasc...@gmail.com on May 24, 2012 03:00:11

r5996 , comment 8 fixed

davidperrenoud commented 10 years ago

From irasc...@gmail.com on May 25, 2012 02:39:14

r5997 dil heights decreased (from original issue report)

davidperrenoud commented 10 years ago

From irasc...@gmail.com on May 25, 2012 03:52:28

r5998 : X9015_DIGI_POT schematic fixed.

Also added and deleted a handful of parts as the lbr files have been updated--need to fix up the googledoc to reflect the changes.

The LTC6244 bug is due to some missing elements in the analog-ic lbr file; apa3010sf4c and luxeon-rebel bugs are problems with the generator.

davidperrenoud commented 10 years ago

From irasc...@gmail.com on May 25, 2012 07:24:23

r6001 : fixed the LTC6244 by adding a element to the xml in SparkFun-AnalogIC.lbr:

Low-noise, high-speed rail-to-rail CMOS op-amp
davidperrenoud commented 10 years ago

From irasc...@gmail.com on May 25, 2012 07:35:57

apa3010sf4c and luxeon-rebel are both smds with an odd number of pads. Will try a general fix for this problem by adding an empty connector to bb view.

davidperrenoud commented 10 years ago

From irasc...@gmail.com on May 25, 2012 08:30:34

r6002 : attempt to deal with bb svgs for smds with an odd number of pads

davidperrenoud commented 10 years ago

From irasc...@gmail.com on June 09, 2012 02:39:05

Labels: -Milestone-0.7.5 Milestone-0.7.6

davidperrenoud commented 10 years ago

From andre.knoerig@gmail.com on June 18, 2012 07:49:22

Slight regression: The breakout boards seem to have all female connectors now, so they don't snap to the breadboard anymore.

davidperrenoud commented 10 years ago

From andre.knoerig@gmail.com on June 23, 2012 07:11:28

Eagle names multiple occurrences of physical pins as "GND@1", "GND@2", and gives them one connector in schematic view. We normally do this by naming them all just "GND", and put multiple connectors on top of each other in schematic view.

I think Eagle's approach is actually more flexible, but it's probably too late to change this now? So the importer should try to be smart about this, and automatically convert Eagle style to our style.

davidperrenoud commented 10 years ago

From h...@supernodegree.com on July 02, 2012 03:43:07

don't change breadboard symbol when switching resistor packages

Status:
Owner: ---
Cc: -andre.knoerig@gmail.com -stefanhermann79@googlemail.com
Labels: -Type-Enhancement -Priority-Critical -Component-Parts -Milestone-0.7.6

Attachment: Bildschirmfoto 2012-07-02 um 12.41.42.png

davidperrenoud commented 10 years ago

From andre.knoerig@gmail.com on July 02, 2012 03:53:05

Status: Started
Owner: irasc...@gmail.com
Cc: andre.knoerig@gmail.com stefanhermann79@googlemail.com h...@supernodegree.com
Labels: Type-Enhancement Component-Parts Milestone-0.7.6

davidperrenoud commented 10 years ago

From irasc...@gmail.com on July 02, 2012 04:41:43

@comment18: probably the same in breadboard view for LEDs, and likely the same for capacitors. Others?

davidperrenoud commented 10 years ago

From h...@supernodegree.com on July 02, 2012 05:49:21

@comment20: yes. it's the same for leds, diodes, relays, crystals, resonators, theres 1 strange voltage regulator.

davidperrenoud commented 10 years ago

From h...@supernodegree.com on July 02, 2012 05:53:10

not sure if those are intended:

1 tantalum and electrolytic caps share the same packages. (same for resonators and crystals)

2 resonators/crystals are listed in semiconductor-group.

davidperrenoud commented 10 years ago

From irasc...@gmail.com on July 04, 2012 23:02:49

All of the generated schematic images (pinheaders, dips, sips, mystery parts, screw terminals) currently use the old schematic sizing spec. I imagine these should be converted to the new spec. For pinheaders, do we prefer the old male/female arrow shapes, or do we move to the rectangle-with-pins representation favored by the sparkfun library?

davidperrenoud commented 10 years ago

From irasc...@gmail.com on July 20, 2012 05:19:18

@comment18: I think these probably need to be marked "programmatic", or maybe "discard" in the googledoc.

davidperrenoud commented 10 years ago

From irasc...@gmail.com on July 20, 2012 05:23:25

@comment24: keep the male/female distinction but redraw them to the new schematic spec

davidperrenoud commented 10 years ago

From irasc...@gmail.com on July 23, 2012 15:20:48

@comment17: r6201

davidperrenoud commented 10 years ago

From irasc...@gmail.com on July 25, 2012 06:20:46

Issue 1790 has been merged into this issue.

Cc: irasc...@gmail.com

davidperrenoud commented 10 years ago

From irasc...@gmail.com on July 25, 2012 06:30:56

Attachment: SchematicViewGraphic_Template1.svg

davidperrenoud commented 10 years ago

From irasc...@gmail.com on August 04, 2012 05:48:02

Adding this comment here, since the discussion is otherwise hidden

Currently each translated lbr file is going into its own bin. This adds another 13 bins to the 6 or so we already have, and having 20 total bin tabs is way too many--the UI becomes unwieldy.

Andre's solution (which Hans is working on) is to reorganize all the parts into around 6 total bins with sections.

Cc: -irasc...@gmail.com bluearc....@gmail.com

davidperrenoud commented 10 years ago

From irasc...@gmail.com on August 04, 2012 06:02:23

Another big issue that is not otherwise documented: what do we do about schematic view, since the new schematic view parts all have a completely different grid size. In particular, what happens to all the old parts. On the one hand we could obsolete every part, which is a logistical nightmare. On the other hand we could change all the old sketches, which would be another kind of nightmare for people who spent time in schematic view.

I have a proposal, which works similarly to the way we made the switch from .fz to .fzz. We declare all old .fzz files read-only. When a user opens an old fzz file, they will be asked whether they want to convert it to the new schematic view. If "yes" a copy of the file is created, and all old schematic images are updated, with whatever chaos occurs with the wiring (or we could autoroute).

I am not sure what to do about old .fz files, in the sense of whether to convert in two steps (i.e. first convert to fzz, then when that is loaded, ask about the schematic conversion), or whether to convert all at once (i.e. once you consent to convert to fzz, schematic is automatically converted as well).

Underneath it all is the following. All old schematic images are moved to the obsolete folder but not renamed. If the file is unconverted, the obsolete image would be used instead of the new image. For obsolete generated parts (mystery part, sip, dip, pinheader) I think the old generator code would have to be available, and if the file is unconverted, the old code would be invoked instead of the new code.

So I would call this nasty but not a nightmare.

Labels: -Milestone-0.7.6 Milestone-0.7.7

davidperrenoud commented 10 years ago

From irasc...@gmail.com on August 04, 2012 06:03:32

Labels: Priority-Critical

davidperrenoud commented 10 years ago

From irasc...@gmail.com on August 04, 2012 06:32:38

More about schematic view. Probably we need to make an svn branch for this code. We should also make a new google doc for the old part schematic view images: for each part, mark whether there is already a new svg to use, whether the new image can be generated (i.e. this is straightforward if the old image uses the standard rectangle style), or whether the new image must be illustrated.

I will generate a first pass of this document.

davidperrenoud commented 10 years ago

From irasc...@gmail.com on August 04, 2012 15:36:25

all the examples will have to be updated for the schematic switchover.

davidperrenoud commented 10 years ago

From irasc...@gmail.com on August 06, 2012 23:14:28

what happens to custom part SVGs during the changeover? Rectangular schematics can be automatically upgraded, but what about the rest. I am tempted to say leave it to the user.

davidperrenoud commented 10 years ago

From irasc...@gmail.com on September 11, 2012 21:02:13

latest schematic template

Attachment: SchematicViewGraphic_Template1_flat.svg

davidperrenoud commented 10 years ago

From irasc...@gmail.com on July 04, 2013 08:31:43

Issue 921 has been merged into this issue.

davidperrenoud commented 10 years ago

From irasc...@gmail.com on July 29, 2013 23:11:35

parts are released.

Status: Fixed