search

fritzing / fritzing-app

Fritzing desktop application
http://fritzing.org
Other
3.97k stars 826 forks source link

schematic view is ignoring 'showInLabel' flag for part properties #2490

Open davidperrenoud opened 10 years ago

davidperrenoud commented 10 years ago

From irasc...@gmail.com on March 31, 2013 01:46:47

What steps will reproduce the problem? 1. 2. 3. Attach your sketch file and/or custom part files to the bug report. If the sketch uses custom parts, save the sketch as shareable (under the file menu). What is the expected output? What do you see instead? What version of Fritzing are you using? On what operating system? Please use labels and text to provide additional information.

Original issue: http://code.google.com/p/fritzing/issues/detail?id=2492

davidperrenoud commented 10 years ago

From irasc...@gmail.com on March 30, 2013 23:06:01

new parts editor is possibly ignoring this as well

davidperrenoud commented 10 years ago

From irasc...@gmail.com on March 31, 2013 03:11:37

r6945 : label display is restored, comment 1 is still open

Status: PartlyDone

failiz commented 3 years ago

Still an issue in 0.9.6. Checked with the part AD5206 Digital Potentiometer.fzp. Remove imported label.

Same problem as in #3648, but the fix #3763 only fixes capacitors. Seeing again my fix, I am not sure if it could be in the constructor of the part instead of in collectExtraInfo(). If we fix this, we will probably will make the code #3763 unnecessary.

failiz commented 3 years ago

I looked into this and I think it is not a bug. The problem is that the power property has not been defined neither in the part file or in the properties.xlm (the default value is ""). Thus, my fix #3763 cannot fix this as the default value is empty. The solution would be to give a default value in properties.xlm or to give a value in the part file.

However, there is a strange behaviour. If you add a AD5206 Digital Potentiometer in the schematic view, the power property is empty in the inspector (which is correct). If now you add a resistor, the power of the AD5206 displays 0.25 (same as the resistor) instead of an empty property. How is it possible that this value jumps from the resistor to the potentiometer??? In any case, it seems that the value is not setting the property of the potentiomneter as it is still not displayed in the schematic view.