search

fritzing / fritzing-app

Fritzing desktop application
http://fritzing.org
Other
3.98k stars 826 forks source link

from the forum: clicking add connector button in parts editor causes crash #716

Closed davidperrenoud closed 10 years ago

davidperrenoud commented 10 years ago

From irasc...@gmail.com on June 13, 2009 05:09:18

Hi,

I have been trying to create custom parts, but Fritzing crushes when try to add a connector.

launch Fritzing choose Part -> New to create a new part load the image (gainer_io.svg) for the breadboard load the image (gainer_io.svg) for the schematic activate the Connectors tab press the "Add connector" button http://files.getdropbox.com/u/36239/fritzing_user_2009-06-13.zip OS: Max OS X 10.5.7 Model: MacBookAir2,1, BootROM MBA21.0075.B03, 2 processors, Intel Core 2 Duo, 1.6 GHz, 2 GB Graphics: kHW_NVidiaGeForce9400MItem, NVIDIA GeForce 9400M, sppci_pci_device, 256 MB

Process: Fritzing [3087] Path: /Applications/fritzing.2009.06.02.mac/Fritzing.app/Contents/MacOS/Fritzing Identifier: org.fritzing.Fritzing Version: ??? (???) Code Type: X86 (Native) Parent Process: launchd [150]

Interval Since Last Report: 266873 sec Crashes Since Last Report: 5 Per-App Interval Since Last Report: 3024 sec Per-App Crashes Since Last Report: 3

Original issue: http://code.google.com/p/fritzing/issues/detail?id=716

davidperrenoud commented 10 years ago

From irasc...@gmail.com on June 13, 2009 02:13:13

The problem occurs if all three part images haven't been loaded yet. A good place to stop the code is in ConnectorsInfoWidget::addConnectorInfo(QString id).

In this case, m_item hasn't been initialized, and Q_ASSERT triggers, which crashes the program. I'm filing a separate bug about Q_ASSERTs.

I'm adding some null checks, but Mariano will need to follow up.

davidperrenoud commented 10 years ago

From irasc...@gmail.com on June 13, 2009 04:59:47

r3136 puts up a warning if all three part images haven't been loaded and the user clicks the "add connector" button. Leaving this open, in case this is not the right fix. Another suggestion would be to disable the button until the three images are loaded.

davidperrenoud commented 10 years ago

From irasc...@gmail.com on June 13, 2009 05:01:29

fixed typo in summary

Summary: from the forum: clicking add connector button in parts editor causes crash

davidperrenoud commented 10 years ago

From meru...@gmail.com on June 16, 2009 04:03:10

Status: Fixed