search

fritzing / fritzing-app

Fritzing desktop application
http://fritzing.org
Other
3.97k stars 826 forks source link

parts need to be better tested when they're added to the core #835

Open davidperrenoud opened 10 years ago

davidperrenoud commented 10 years ago

From irasc...@gmail.com on September 22, 2009 18:04:38

For example, testing could come in two flavors: manual and programmatic

Manual: drop it into a sketch: export etchable svg export plain svg (all 3 views) what happens when you hide layers (particularly PCB view) export to gerber?

Programmatic: add to fritzing code, or make available elsewhere: remove inkscape elements and attributes (this code already in the parts editor, but it doesn't yet remove elements) flatten transforms (much of this code is working, but not completely, and is not well tested) missing viewBox or units (this is in the parts editor--are all known cases covered?)

Original issue: http://code.google.com/p/fritzing/issues/detail?id=835

davidperrenoud commented 10 years ago

From irasc...@gmail.com on September 27, 2010 13:55:38

Labels: Component-Parts

davidperrenoud commented 10 years ago

From irasc...@gmail.com on October 04, 2010 23:48:32

missing layer ID, layer ID in the element, layer ID at the wrong level

Owner: andre.knoerig
Cc: -andre.knoerig -merunga

davidperrenoud commented 10 years ago

From irasc...@gmail.com on October 04, 2010 23:49:11

In general, need to develop a QA recipe to follow with all parts

failiz commented 3 years ago

move to parts repository?

KjellMorgenstern commented 3 years ago

I think this would require some support from the fritzing application, like an addtional command line option to check a part. Currently I think this only exists for projects. This could then be used together with github actions (in the part repository) to render a report for new / changed parts. We could use https://percy.io/visual-testing for this, we have an OSS account there.

failiz commented 3 years ago

Could we use/integrate https://github.com/vanepp/FritzingCheckPart for this? At least to not have to start from scratch. The visual inspection it would be nice.

KjellMorgenstern commented 3 years ago

I started a PR https://github.com/fritzing/fritzing-parts/pull/270 for including more test scripts. Last time I checked, the FritzingCheckPart script still needed many modification to be suitable for CI.

See https://github.com/fritzing/fritzing-parts/issues/88 for parts CI improvements. Lets focus on the fritzing app changes (like automated loading of parts via CLI) here.