search

fritzing / fritzing-parts

Electronic components for use in the Fritzing app (aka the parts library)
http://fritzing.org/parts
Other
510 stars 359 forks source link

Heltec WiFi LoRa 32 module #230

Closed UniquePete closed 4 years ago

UniquePete commented 4 years ago

Offering Heltec WiFi LoRa 32 module for inclusion in fritzing-parts

UniquePete commented 4 years ago

This is my first attempt to submit anything to GitHub, but this does appear to be a Fritzing-specific issue. Either way, can anyone offer any advice on what's gone wrong here (I'm assuming that this comment will be tied to the failure report that I received) and, perhaps more importantly, how I can rectify the problem?

Thanks.

KjellMorgenstern commented 4 years ago

The failure is related to our toolchain, it seems so package from the Go language received an incompatible update. But you should remove the .DS_Store files, they are from MacOS and don't have anything to do with the Fritzing parts. As a rule of thumb for using git, when calling 'git add' give the exact files names, almost never use wildcards or add complete directories.

UniquePete commented 4 years ago

Thanks for that, but what do I do now? Just try again? How will I know when the Go language package is OK again?

As for the .DS_Store files, yes I saw them appear (and figured that they were unnecessary) but I was using GitHub Desktop and I think that just clones the whole directory, no matter what I try to do. If I were to delete the .DS_Store files, I think they’d just get put back again… or is there something I can do to stop that?

This is the first time that I’ve done anything on GitHub, so I’m a complete novice. I thought the Desktop app would make things easier, but I can work out the CLI side of things if need be.

Pete

On 2 Jan 2020, at 12:09 AM, Kjell notifications@github.com wrote:

The failure is related to our toolchain, it seems so package from the Go language received an incompatible update. But you should remove the .DS_Store files, they are from MacOS and don't have anything to do with the Fritzing parts. As a rule of thumb for using git, when calling 'git add' give the exact files names, almost never use wildcards or add complete directories.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/fritzing/fritzing-parts/pull/230?email_source=notifications&email_token=AJE55452GJI4A7SLM7K455TQ3SI2FA5CNFSM4KBVHPCKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEH5E3LI#issuecomment-570052013, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJE5542HULQXQTPGLITRPYTQ3SI2FANCNFSM4KBVHPCA.

KjellMorgenstern commented 4 years ago

Hello, I fixed the broken test script (the CLI parser API had changed upstream), and all the tests now pass. However you overlooked some of the .DS_store files. Also, I saw you published another version on the forum. Or is that the same version as in this pull request?

UniquePete commented 4 years ago

No, I think the forum version just has a slightly modified Breadboard/Icon image following the creation of a part for the V2 module. I'll get all of the parts I posted on the forum over here in the next couple of days.

KjellMorgenstern commented 4 years ago

Closing, as this PR doesn't seem to contain any files except .DS_store garbage data.