search

fritzing / fritzing-parts

Electronic components for use in the Fritzing app (aka the parts library)
http://fritzing.org/parts
Other
513 stars 359 forks source link

get rid of all internal px in the core #320

Open davidperrenoud opened 10 years ago

davidperrenoud commented 10 years ago

From irasc...@gmail.com on May 03, 2013 11:28:32

What steps will reproduce the problem? 1. 2. 3. Attach your sketch file and/or custom part files to the bug report. If the sketch uses custom parts, save the sketch as shareable (under the file menu). What is the expected output? What do you see instead? What version of Fritzing are you using? On what operating system? Please use labels and text to provide additional information.

Original issue: http://code.google.com/p/fritzing/issues/detail?id=2550

failiz commented 3 years ago

The core is full of px, but not sure what is the issue. @KjellMorgenstern , you decide

KjellMorgenstern commented 3 years ago

TinySVG only uses numbers, sometimes also called "units" . Strings like px and cm are only used when defining the framesize. Which makes kind of sense, since everything else may be scaled, and a px or a cm would be subject to transformations. Only later standards which bring CSS 2.1 to SVG have px. Fritzing removes those when parsing svg, but there where already multiple bugs when the px caused a method that expected a number to fail.

failiz commented 3 years ago

But is this an issue of the app or of the parts? If the later, should we move this to the parts repo?