Fix PR349 - Githubissues

fritzing / fritzing-parts

Electronic components for use in the Fritzing app (aka the parts library)

http://fritzing.org/parts

Other

505 stars 358 forks source link

Fix PR349 #370

Open KjellMorgenstern opened 1 year ago

KjellMorgenstern commented 1 year ago

[ ] In PR349 the layer for the breadboard view should have been "breadboardbreadboard" instead.
[ ] ensure gerber export works
stroke-width has been applied to groups, which does not work with Fritzing 0.9.10. Check with Fritzing 1.0.0 development that this now indeed works, and post a screenshot here (or fix it)
circles instead of ellipses might be needed. It does not seem to be a problem though.

https://github.com/fritzing/fritzing-parts/pull/349

vanepp commented 1 year ago

circles instead of ellipses might be needed. It does not seem to be a problem though.

That is a problem in the pcb svg, but doesn't appear to be present in mine (the pads are all circles and FritzingCheckPart.py checks for that.) Ellipses in the pcb svg will not generate holes in the gerber output (while showing fine in Fritzing!)