search

fritzmg / contao-sharebuttons

Simple extension to provide share buttons as a module and content element in Contao
GNU Lesser General Public License v3.0
18 stars 2 forks source link

Let content element and modules only create an insert tag #17

Closed fritzmg closed 9 years ago

fritzmg commented 9 years ago

This would solve #5

For example, if you have integrated a share buttons module before the newsreader (due to your layout), $objPage will not have the correct page title set yet. Thus you would either have to rely on echo $this->sharebuttons; in your news_full template, or move the share buttons module or content element somewhere after the newsreader module. This is a bit restricting.

To circumvent this, the share buttons content element and module could simply produce an insert tag instead, which would then be replaced after the whole page has been generated - and thus the correct page title would definitely be present in $objPage.

This change requires #16

fritzmg commented 9 years ago

Implemented in b47a05b0dcbb4d7bccfb14f41ffd23a13c32ec76