search

fritzmg / contao-sharebuttons

Simple extension to provide share buttons as a module and content element in Contao
GNU Lesser General Public License v3.0
18 stars 2 forks source link

Add "print website" and "pdf" #36

Closed k-webdesign closed 5 years ago

k-webdesign commented 5 years ago

Hi,

is it possible to add "print website" and "generate pdf" to replace the core syndication completely if wanted?

fritzmg commented 5 years ago

The problem here is that not everyone of these freely available icon sets do have a "print" and "pdf" icon in them. I'll have to build them myself. Or someone needs to build them for me ;)

k-webdesign commented 5 years ago

Could we use font awesome for this case? or better nor because of performance reasons?

fritzmg commented 5 years ago

For the font awesome themes it's not a problem. It's an issue for the other themes. Sure, I can take the font awesome icon, but I still need to build everything myself ;). Especially for the "Shadow" theme.

k-webdesign commented 5 years ago

I see 🤔I'll think about it

fritzmg commented 5 years ago

What I can do is make the necessary code and template adjustments only. Then users who use the additional buttons would need to take care of the CSS (and images) themselves, until I or someone else has built the appropriate PNGs (or SVGs) and CSS. After all, the "Contao" theme does not support every button either.

k-webdesign commented 5 years ago

That would be a nice solution!

I found this one here which has some pretty nice print and PDF icons: https://icons8.com/icons/set/print - free commercial use for a link (https://icons8.com/license)

fritzmg commented 5 years ago

Implemented in 6d4106b5323b83f520a97f3d11969c5f1c3f7dd5