search

fritzo / google-breakpad

Automatically exported from code.google.com/p/google-breakpad
0 stars 0 forks source link

Patch for better version handling in minidump for Mac binaries #303

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
This patch extracts and sets the version of the main executable if present in 
the __TEXT __version 
section. It also handle versions when we're in the same process as the crashed 
process.

Original issue reported on code.google.com by cedric.l...@gmail.com on 18 Mar 2009 at 11:07

Attachments:

GoogleCodeExporter commented 9 years ago 
Hi cedric, I'm interested in taking your patch (sorry for the delay!) Do you 
have a
contributor agreement on file with Google? If not, could you fill out the form 
(you
can do it on the webpage):
http://code.google.com/legal/individual-cla-v1.0.html

Google needs to have this on file for everyone we take non-trivial patches from.

Thanks!

Original comment by ted.mielczarek on 11 Sep 2009 at 11:41

GoogleCodeExporter commented 9 years ago 
I just agreed to the CLA.

Also, after further testing,  I changed the __version to go to the __DATA 
segment instead of the __TEXT segment.
You should replace SEG_TEXT with SEG_DATA and __TEXT with __DATA in the patch. 
I don't remember the exact 
problem, but it was definitely not working well when in the __TEXT segment.

Original comment by cedric.l...@gmail.com on 12 Sep 2009 at 6:13