Invalid Python 3 syntax in XEP-0009 plugin

fritzy / SleekXMPP

Python 2.6+/3.1+ XMPP Library

http://groups.google.com/group/sleekxmpp-discussion

Other

1.1k stars 299 forks source link

Invalid Python 3 syntax in XEP-0009 plugin #491

Open dos1 opened 6 years ago

dos1 commented 6 years ago

writing byte-compilation script '/tmp/tmp7db23s0r.py'
/usr/bin/python /tmp/tmp7db23s0r.py
  File "usr/lib/python3.7/site-packages/sleekxmpp/plugins/xep_0009/remote.py", line 430
    def async(self, callback):
            ^
SyntaxError: invalid syntax

kekePower commented 5 years ago

This really needs to be fixed. We can't keep patching just to maintain a package.

Neustradamus commented 5 years ago

@dos1 @kekePower: Any news?

Have you tested with "master"?

https://github.com/fritzy/SleekXMPP/commits/develop

It works?

If not, have you a patch? Can you create a PR?

vitlav commented 5 years ago

@dos1 @kekePower: Any news?

Have you tested with "master"?

https://github.com/fritzy/SleekXMPP/commits/develop

It works? There are no changes in develop branch with that plugin.

vitlav commented 5 years ago

Come somebody check that patch? https://lab.louiz.org/poezio/slixmpp/commit/a88f317bbfe0cc725aa32a5329dc7b45532c11b4