search

fritzy / SleekXMPP

Python 2.6+/3.1+ XMPP Library
http://groups.google.com/group/sleekxmpp-discussion
Other
1.1k stars 299 forks source link

Event handler execution should be surrounded by a try block #65

Closed thom-nic closed 13 years ago

thom-nic commented 13 years ago

Currently if a 'direct' event handler raises an uncaught exception it prevents other event handlers from receiving the event.

Queued events are properly enclosed in a 'try' block (in XMLStream._event_runner) however 'direct' events are not - see: sleekxmpp/xmlstream/xmlstream.py:532 (from Fritzy's 'master' branch)

legastero commented 13 years ago

Fixed in develop branch. Note that event handlers will all run in the same thread if using a direct event.

thom-nic commented 13 years ago

Yup! I know it's not normally used (the queue is ideal IMO) but just wanted to make sure all conditions were covered. Thanks!