search

frizbog / gedcom4j

Java library for reading/writing genealogy files in GEDCOM format
http://gedcom4j.org
55 stars 37 forks source link

Parsing lines with level > 9 #102

Closed ghost closed 8 years ago

ghost commented 8 years ago

I was just reading through some of the source (great work!) and noticed a minor potential issue and thought I'd at least document it. It doesn't appear that the constructor for org.gedcom4j.parser.LinePieces will properly handle lines where the level is two digits. I'd earlier noticed that the spec says "Level numbers must be between 0 to 99..." so I'm thinking it should technically be possible for the level to be greater than nine (ref pg 10 of the 5.5.1 draft standard).

frizbog commented 8 years ago

Good catch. Technically possible (though unlikely), so I will fix this. Thanks for reporting it!

frizbog commented 8 years ago

Fixed in v2.2.8-SNAPSHOT

ghost commented 8 years ago

Count me as a fan - thanks Matt!

frizbog commented 8 years ago

:-D

This email just made my day. Cheers!

M

On Jun 6, 2016, at 9:21 PM, Daniel Magsig notifications@github.com wrote:

Count me as a fan - thanks Matt!

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/frizbog/gedcom4j/issues/102#issuecomment-224135976, or mute the thread https://github.com/notifications/unsubscribe/ACxHYYL2yBTJJoM7-GyNwA4Hue1axj_Rks5qJMepgaJpZM4Iuh1g.

frizbog commented 8 years ago

Released in v2.2.8.