frizbog / gedcom4j

Java library for reading/writing genealogy files in GEDCOM format
http://gedcom4j.org
55 stars 37 forks source link

Multiple code improvements - squid:S1155, squid:S1066, squid:S1213, squid:UselessParenthesesCheck #90

Closed georgekankava closed 8 years ago

georgekankava commented 8 years ago

This pull request is focused on resolving occurrences of Sonar rules squid:S1155 - Collection.isEmpty() should be used to test for emptiness. squid:S1066 - Collapsible "if" statements should be merged. squid:S1213 - The members of an interface declaration or class should appear in a pre-defined order. squid:UselessParenthesesCheck - Useless parentheses around expressions should be removed to prevent any misunderstanding. You can find more information about the issue here: https://dev.eclipse.org/sonar/rules/show/squid:S1155 https://dev.eclipse.org/sonar/rules/show/squid:S1066 https://dev.eclipse.org/sonar/rules/show/squid:S1213 https://dev.eclipse.org/sonar/rules/show/squid:UselessParenthesesCheck Please let me know if you have any questions. George Kankava