frizzant / league-of-legends-rankify

This plugin extends the sinusbot to connect with the RIOT API and get the correct rank, level, role and ingame-status
MIT License
2 stars 1 forks source link

Not adding groups #2

Closed frizzant closed 4 years ago

frizzant commented 4 years ago

Clients don't get all the servergroups that would be expected.

Reocurring error with var level is not a number which indicates that the API call is returned empty. 3 response types: 400 Bad Request 403 Forbidden 404 Not Found Download

2020-02-24T20:43:49+01:00 [ bootstrap.js:1:949] 404 Not Found 2020-02-24T20:43:49+01:00 Unhandled rejected promise: [object Object] 2020-02-24T20:43:49+01:00 Unhandled rejected promise: 404 Not Found 2020-02-24T20:43:49+01:00 queued serialized callback 2020-02-24T20:43:49+01:00 queued serialized callback 2020-02-24T20:43:49+01:00 [ bootstrap.js:1:949] 404 Not Found 2020-02-24T20:43:49+01:00 Unhandled rejected promise: [object Object] 2020-02-24T20:43:49+01:00 Unhandled rejected promise: 404 Not Found 2020-02-24T20:43:49+01:00 queued serialized callback 2020-02-24T20:43:49+01:00 queued serialized callback 2020-02-24T20:43:49+01:00 [ bootstrap.js:1:949] 404 Not Found 2020-02-24T20:43:49+01:00 Unhandled rejected promise: [object Object] 2020-02-24T20:43:49+01:00 Unhandled rejected promise: 404 Not Found 2020-02-24T20:43:49+01:00 queued serialized callback 2020-02-24T20:43:49+01:00 queued serialized callback 2020-02-24T20:43:49+01:00 registered callback for event serverGroupAdded

Possible timing issue?

frizzant commented 4 years ago

Seems to have been resolved through moving the clear array from front of function to the end.

.then(result => {
      requestArray = []
      resolve(result)
})

Waiting for confirmation from users.