frjo / hugo-theme-zen

A fast and clean Hugo base theme with css-grid and Hugo pipes support.
https://zen-demo.xdeb.org/
GNU General Public License v2.0
276 stars 80 forks source link

Responsive table JS not working on Microsoft Edge 112 #88

Closed danielfdickinson closed 1 year ago

danielfdickinson commented 1 year ago

https://github.com/frjo/hugo-theme-zen/commit/a5e759d988da5ed4071ac575c4253e8e9bd056f0#r110247012

For me, on Microsoft Edge 112 'tr:has(td)' doesn't work, but using 'tbody tr' does.

I also see on MDN that :has is not supported on Firefox without manual enablement by user and not at all on Firefox for Android.

frjo commented 1 year ago

And I who really like the new ":has()" selector :-). Made some changes now, can you confirm it fixes the issue?

Checked https://caniuse.com/?search=%3Ahas and it should work for Edge but not always apparently.

danielfdickinson commented 1 year ago

That works on Edge quite well...Unfortunately it does not work on Firefox with default settings.

frjo commented 1 year ago

Oops, I realised I missed that the js is using :has() as well. Fixed now.

danielfdickinson commented 1 year ago

It's solved. Thank you.