search

frksteenhoff / ClimApp

Codebase for prototype and final version of the smartphone application ClimApp, a project under the European Research Area for Climate Services. The application is available for iOS and Android in App Stroe and Google Play respectively.
https://www.lth.se/climapp/
4 stars 2 forks source link

Weather logic - LOCATION issue #92

Closed BorisKingma closed 5 years ago

BorisKingma commented 5 years ago

The as is situation checks your current location in a database

suggest to lower the distance criterion to 1km.

pro = better localisation of weather report con = increased probability that no historical comparison can be made.

frksteenhoff commented 5 years ago

Could we maybe combine it such that the current weather is fetched from your more or less exact location (as we did in the Android version of the app) and then fetch the forecast data as we do it currently?

BorisKingma commented 5 years ago

weather forecast and current weather should be about the same coordinate.

the current weather request should also be available from database. The issues about Time and Location are closely linked, but I think they are easier to oversee and decide on as separate issues.

-- for context

The reason why we stopped using the original android functionality (request current weather ad hoc) is that we foresee that we can go over the fair use policy of Openweathermap. It that happens, all users are affected.

That's why we chose the route of the database and the distance criterion to prevent calls to openweather when not needed. At the same time, we require a time criterion to force a new weather report if the last stored weather forecast may be outdated for the current situation.

We have to keep in mind that requesting current and forecast means 2 api calls to openweathermap per use of the app, leaving us to 30 app uses per minute in total worldwide.

BorisKingma commented 5 years ago

The solution is to ask for

current weather forecast

in the same database call.

however, it is the criteria distance < 1km? time < 60min?

we should decide on.

Nybo72 commented 5 years ago

When the new version is ready for testing I suggest we also invite Marco/Alessandro + other heat-shield to register and see how it has developed (for inspiration and integration).

Also we can talk during the day when needed. Bw Lars

From: Boris [mailto:notifications@github.com] Sent: 23. april 2019 14:36 To: frksteenhoff/ClimApp Cc: Lars Nybo; Assign Subject: Re: [frksteenhoff/ClimApp] Weather logic - LOCATION issue (#92)

The solution is to ask for

current weather forecast

in the same database call.

however, it is the criteria distance < 1km? time < 60min?

we should decide on.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHubhttps://github.com/frksteenhoff/ClimApp/issues/92#issuecomment-485784125, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AH4U45UFB5DZGQ52UDLBQYLPR37CTANCNFSM4HHODVGQ.