frmatthew / exsurge

A JavaScript library for rendering Gregorian Chant in square note notation
MIT License
54 stars 13 forks source link

Bar lines immediately after new system #65

Closed bbloomf closed 8 years ago

bbloomf commented 8 years ago

I'm not certain, but I think there is a rule that a system shouldn't start with a bar line; anyway it looks strange to me when it puts a line break such that it starts with a bar line.

frmatthew commented 8 years ago

I fixed this and closed the issue, but just realized that there are other notations that probably shouldn't start a new line... clefs for instance? Any others?

olivierberten commented 8 years ago

You can start a new line with a new clef, as long as the custos is set according to the new clef.

frmatthew commented 8 years ago

Thanks @olivierberten: In the case where the clef change is the first notation for the line, is the previous clef supposed to be displayed first, or does the new clef simply take the place of the previous clef as the first on the line? I.e., is this correct:

clef change

or should the c3 clef simply not be rendered on the second line?

olivierberten commented 8 years ago

This is indeed a mistake... c3 shouldn't be rendered.

frmatthew commented 8 years ago

Thanks @olivierberten, the above commit should resolve the clef change at the start of the line now.