Duplication of entities insert and refactoring of library use - Githubissues

frmscoe / tms-service

1 stars 3 forks source link

Duplication of entities insert and refactoring of library use #191

Closed Lenbkr closed 1 week ago

Lenbkr commented 1 week ago

What did we change?

Removing the duplicate entity insertions as per #190 Removed: https://github.com/frmscoe/tms-service/blob/d679470cc691ed8cbed142eab760b133ac60fb85/src/logic.service.ts#L240-L241 Kept: https://github.com/frmscoe/tms-service/blob/d679470cc691ed8cbed142eab760b133ac60fb85/src/logic.service.ts#L255-L257

Structural Changes

Restructured config object so that it is more in line with the other processors by grouping database envs
Refactored CacheDatabaseManager instance so we don't export two DatabaseManagers with a better export name

Why are we doing this?

Structural: Internal imports are simpler to understand their intent by having a more coherent structure.

How was it tested?

[x] Locally
[x] Development Environment
[ ] Not needed, changes very basic
[x] Husky successfully run
[x] Unit tests passing and Documentation done

sonarcloud[bot] commented 1 week ago

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud