search

froala / KMSFroalaEditorBundle

Symfony bundle for Froala WYSIWYG HTML Rich Text Editor.
https://froala.com/wysiwyg-editor
105 stars 33 forks source link

Doctrine inflector upgrade #113

Closed jmsche closed 4 years ago

jmsche commented 4 years ago

Hi,

I created this PR to fix recent deprecations with doctrine/inflector 1.4.x and to allow the 2.0 version.

I also added a test to check the function in PluginProvider works the same as before (tested locally using 1.4 & 2.0 versions).

I had to upgrade the min PHP version to 7.2 as both 1.4 & 2.0 versions of the inflector made the move. I think it's not a problem as PHP 7.1 is not supported anymore.

When releasing/tagging, you should create a 3.1.0 version/tag and not 3.0.4 as the dependency bumps should not be a patch upgrade.

jmsche commented 4 years ago

@sguionni Could you please tag a 3.1.0 release?

sguionni commented 4 years ago

Done!

jmsche commented 4 years ago

Thank you