search

froala / KMSFroalaEditorBundle

Symfony bundle for Froala WYSIWYG HTML Rich Text Editor.
https://froala.com/wysiwyg-editor
105 stars 33 forks source link

Make bundle compatible with symfony 2.6 #3

Closed Intrepidity closed 9 years ago

Intrepidity commented 9 years ago

The bundle requires a version of symfony lower than 2.6.

Does anything need to happen to make it compatible or can you just bump the requirement in composer.json?

stefanneculai commented 9 years ago

@samarhxc any thoughts on this one?

Intrepidity commented 9 years ago

I quickly reviewed the symfony 2.5 to 2.6 upgrade documentation and I don't think there's any relevant BC breaks there. I think it's a matter of bumping it in the develop branch and just trying it out..

stefanneculai commented 9 years ago

I believe that too. @samarhxc has created this bundle and he should be more familiar. If you could give it a try that would be great.

sguionni commented 9 years ago

I updated the composer.json requirement (i don't really know what to set but the bundle is working for me with the last symfony release).

Intrepidity commented 9 years ago

Thanks, we're testing it on our side right now. I'll get back to you on the results next week as I'm AFK the coming days. :)

Intrepidity commented 9 years ago

Perfect, works like a charm :) Consider this issue closed :+1:

sguionni commented 9 years ago

Nice, take a look to the documentation, i comitted some updates ;)