Code style/static analysis

froala / KMSFroalaEditorBundle

Symfony bundle for Froala WYSIWYG HTML Rich Text Editor.

https://froala.com/wysiwyg-editor

105 stars 33 forks source link

Code style/static analysis #91

Closed jmsche closed 3 years ago

jmsche commented 5 years ago

Hi @sguionni,

I'm wondering if you're open to a massive code refactor? Here's what I'd like to do:

Setup phpstan for static analysis
Setup phpcs (not many rules, eg. enforce spaces instead of tabs, short array syntax...) for code style
Remove useless comments & rename some parameters (maybe functions too)
Setup a travis config to make phpstan/phpcs run for PRs

WDYT?

sguionni commented 5 years ago

I think it's a good idea, i started this bundle long time ago and i have no time to maintain it anymore, so go ahead!

jmsche commented 5 years ago

Thanks, I'll start working on it after the docs update :)

AxelBriche commented 4 years ago

Hello, some news? This bundle is ready for the futur? Thanks.

jmsche commented 4 years ago

Hello @AxelBriche, code style & static analysis are not done yet, but the bundle works well with last minor of Symfony (5.1).

mpoiriert commented 4 years ago

Hi @jmsche The bug https://github.com/froala/KMSFroalaEditorBundle/issues/17 to be fixed will need a renaming of all form type options and will cause a BC.

Doing both at the same time would help. I will fork this project because I need this ASAP for a client. But maybe we can work together to make this more "Symfony" friendly.

jmsche commented 3 years ago

Done with 4.0.0 release.