froala / angular-froala-wysiwyg

Angular 4, 5, 6, 7, 8 and 9 plugin for Froala WYSIWYG HTML Rich Text Editor.
https://froala.com/wysiwyg-editor
735 stars 202 forks source link

Angular 10: Function calls are not supported in decorators but 'froalaeditormodule' was called. #439

Open 1-0-1 opened 4 years ago

1-0-1 commented 4 years ago

I am trying to update to Angular 10 for a library project which includes froala but am getting errors on build: Error during template compile of 'NgxLibModule' Function calls are not supported in decorators but 'FroalaEditorModule' was called. Error during template compile of 'NgxLibModule' Function calls are not supported in decorators but 'FroalaViewModule' was called.

If I remove reference to these modules, it builds.

Angular CLI: 10.1.4 Node: 14.13.0 OS: win32 x64

Angular: 10.1.4 ... animations, cli, common, compiler, compiler-cli, core, forms ... language-service, platform-browser, platform-browser-dynamic ... router Ivy Workspace: No

Package Version

@angular-devkit/architect 0.1001.4 @angular-devkit/build-angular 0.1001.4 @angular-devkit/build-ng-packagr 0.1001.4 @angular-devkit/core 10.1.4 @angular-devkit/schematics 10.1.4 @angular/cdk 8.2.3 @schematics/angular 10.1.4 @schematics/update 0.1001.4 ng-packagr 10.1.2 rxjs 6.6.3 typescript 3.9.7

shah20 commented 4 years ago

+1

leo6104 commented 4 years ago

I guess #329 will resolve these issue. We have to use ng-packagr to build Angular library.

angular-froala-wysiwyg still use ngm cli to build library. ngm cli is not maintained for 2 years.

SaiTejaLamkam commented 4 years ago

Any solution for this issue, facing same issue didn't find any solution

temaisgod commented 4 years ago

+1

1-0-1 commented 4 years ago

Hello? Is anybody out there? Now Angular 9 is failing, too: Unexpected value 'FroalaEditorModule in .../node_modules/angular-froala-wysiwyg/editor/editor.module.d.ts' imported by the module ... Please add a @NgModule annotation. Unexpected value 'FroalaViewModule in .../node_modules/angular-froala-wysiwyg/view/view.module.d.ts' imported by the module .... Please add a @NgModule annotation.

UPDATE Latest was installed and anything newer than 3.1.1-2 will not work with Angular 9.

temaisgod commented 4 years ago

Hello? Is anybody out there? Now Angular 9 is failing, too: Unexpected value 'FroalaEditorModule in .../node_modules/angular-froala-wysiwyg/editor/editor.module.d.ts' imported by the module ... Please add a @NgModule annotation. Unexpected value 'FroalaViewModule in .../node_modules/angular-froala-wysiwyg/view/view.module.d.ts' imported by the module .... Please add a @NgModule annotation.

Hi! I have a same peoblem. I think this problem is because use aot compilation without IVY, change the compilation options in angular. Json and use aot false.

GlauberF commented 4 years ago

+1


Angular CLI: 11.0.1
Node: 12.18.1
OS: linux x64

Angular: 11.0.0
... animations, cdk, common, compiler, compiler-cli, core, forms
... language-service, material, material-moment-adapter
... platform-browser, platform-browser-dynamic, platform-server
... router, service-worker
Ivy Workspace: Yes

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.1002.0
@angular-devkit/build-angular     0.1100.1
@angular-devkit/build-optimizer   0.1100.1
@angular-devkit/core              10.2.0
@angular-devkit/schematics        11.0.1
@angular/cli                      11.0.1
@angular/flex-layout              11.0.0-beta.33
@nguniversal/builders             11.0.0
@nguniversal/express-engine       11.0.0
@schematics/angular               11.0.1
@schematics/update                0.1100.1
rxjs                              6.6.3
typescript                        4.0.5

elmartino commented 3 years ago

+1

1-0-1 commented 3 years ago

Update: From the Froala support team: "As the Github channel is considered a place to get public support, we strongly recommend that you report the problem via the Support channel in the future in order to get technical support as soon as possible."

You can find that on the support page of the main Froala web site.

As to this issue, their response: "I just got a confirmation from the dev team. At this moment Froala does not support disabling the Ivy compiler.

"angularCompilerOptions": { "enableIvy": false }

The mentioned pull request should address this issue: https://github.com/froala/angular-froala-wysiwyg/pull/329.
The dev team will test it in the next cycle. If the PR passes all the necessary checks, it will be merged in January release."

leo6104 commented 3 years ago

@1-0-1 Thanks for sharing. I resolved all conflicts in #329 . Hope it could be merged. :)

andreloureiro88 commented 3 years ago

Please Merge this guys. It's totally preventing me from udating my project to angular 11. If this was a free package i would understand but cm'on guys it's a paid service. Keeping your packages up to date is the least you can do. Ivy is here since angular 9.

timmyrosen commented 3 years ago

This is the reason we went away from froala. They don't care about the angular community. It's a shame since it's a great editor.

labrada83 commented 3 years ago

+1

prernagp commented 3 years ago

it's a shame that it is still not fixed.