search

froala / angular-froala

Angular.js bindings for Froala WYSIWYG HTML Rich Text Editor.
https://froala.com/wysiwyg-editor
MIT License
306 stars 123 forks source link

Open in new tab not working #180

Closed ktracey closed 6 years ago

ktracey commented 6 years ago

'Open in new tab' Save and test the link, opens in same tab Edit link and box is unchecked.

This appears to work with the native froala editor... but is not working within the angular component.. This is a problem in 2.8.0..Works in 2.7.6

AshMcConnell commented 6 years ago

We are actually seeing something slightly different. QA are reporting it always opens in a new browser window rather than a new tab or same window

ktracey commented 6 years ago

That is not what we seeing.. we are seeing that the value of "open in new tab" is not being retained...and it always opens in the same window.. I just tried it again with 2.8.3 step1 step2 step3

stefanneculai commented 6 years ago

We just checked this in version 2.8.4 and it works without problem on https://www.froala.com/wysiwyg-editor. If you still have problem you might have a custom implementation that prevents it to work correctly.

ktracey commented 6 years ago

Does your example on https://www.froala.com/wysiwyg-editor use the angular -froala?

stefanneculai commented 6 years ago

@ktracey the angular example doesn't make any changes on the HTML. I would recommend to check the output of the following command in the browser to see what version you're using: $.FE.VERSION.

ktracey commented 6 years ago

I figured it out.. We bundle all of our third party components.. and perform a minification on them. For some reason this is causing an issue with this feature with the 2.8.x version of Froala (it was fine in the 2.7.x versions). I just wanted to document my findings in case others have the same issue