froala / angular-froala

Angular.js bindings for Froala WYSIWYG HTML Rich Text Editor.
https://froala.com/wysiwyg-editor
MIT License
306 stars 123 forks source link

Exactly the same error than in Angular-froala-WYSIWYG html.set is not a function #181

Closed mthomasson closed 6 years ago

mthomasson commented 6 years ago

See https://github.com/froala/angular-froala-wysiwyg/issues/206 We have exactly the same error in the Angular 1 version.

mthomasson commented 6 years ago

@stefanneculai This commit https://github.com/mthomasson/angular-froala/commit/0930ae307322e8c276a398888c6327c094dc6723 solves it

jacobcsmith commented 6 years ago

We're also experiencing this issue

petarblazevski commented 6 years ago

@stefanneculai when you install the package with npm it installs the latest version 2.8.4 with the issue fixed. But if you install the package with bower you are still getting 2.8.3. Looking at the Release in GitHub, the latest release is flagged as 2.8.3. Maybe this is the issue with bower?

DallanQ commented 6 years ago

@petarblazevski I believe the problem is bower relies upon the github "release" tags, and there isn't a release tag for 2.8.4, so we have to use the git sha instead.