ng-required option with ng-model is not working correctly

froala / angular-froala

Angular.js bindings for Froala WYSIWYG HTML Rich Text Editor.

https://froala.com/wysiwyg-editor

MIT License

306 stars 123 forks source link

ng-required option with ng-model is not working correctly #215

Open tajinderjit13 opened 5 years ago

tajinderjit13 commented 5 years ago

When using ng-required or required attribute on textarea the modelValue is set to undefined. This is happening mainly because the $isEmpty function is always returning true. https://github.com/froala/angular-froala/blob/master/src/angular-froala.js#L97

tajinderjit13 commented 5 years ago

Pull Request for the above fix https://github.com/froala/angular-froala/pull/216 @navneetnagpal @stefanneculai

robinwassen commented 4 years ago

@navneetnagpal

Seems like you should merge this since it has gone 3 months and the PR is a straight forward oneliner that fixes one of the many issues with this library.