search

froala / ember-froala-editor

Ember component for Froala WYSIWYG HTML Rich Text Editor.
https://froala.com/wysiwyg-editor
MIT License
69 stars 35 forks source link

Test `ember-canary` scenario/channel #141

Closed Panman82 closed 1 year ago

Panman82 commented 1 year ago

The ember-canary test scenario was removed from the GH Workflow due to errors with the pending ember.js v5 release. I'm creating this PR so it is easy to re-test the canary channel as thing change with ember.js development.

Panman82 commented 1 year ago

Trying to get this to pass with help on https://github.com/emberjs/ember.js/issues/20418

Panman82 commented 1 year ago

Will try again once render-modifiers allow ember v5: https://github.com/emberjs/ember-render-modifiers/pull/70

EDIT: PR is merged, but waiting for a new version release.

Panman82 commented 1 year ago

Well, new version of the froala-editor necessitates a new release here, but render-modifiers has yet to release with the potential fix. So I'm just going to merge this PR with failing test, update ember to v4.12, update froala editor and release this addon... 😕