search

froala / ember-froala-editor

Ember component for Froala WYSIWYG HTML Rich Text Editor.
https://froala.com/wysiwyg-editor
MIT License
69 stars 34 forks source link

Add TypeScript types for the addon components and helpers #62

Open Panman82 opened 6 years ago

Panman82 commented 6 years ago

Apparently there is a types file that can be added to help with TypeScript support. Probably worth adding since the ember community is moving that direction.

https://github.com/typed-ember/ember-cli-typescript/issues/48

Panman82 commented 1 year ago

Just to add here, there is an open issue on the main editor repo (upstream from this Ember addon) requesting that TypeScript definitions be added: https://github.com/froala/wysiwyg-editor/issues/2369

Panman82 commented 1 year ago

Once this addon moves to embroider (addon v2) format, the actual components/helpers/etc. will move to "native" TypeScript files with all the types needed.

Panman82 commented 1 year ago

Just to note, there is apparently upstream types available now, but I haven't looked into them yet: https://github.com/froala/wysiwyg-editor/issues/2369