search

froala / wysiwyg-editor-php-sdk

PHP SDK to ease the integration of Froala WYSIWYG Editor on server side.
https://www.froala.com/wysiwyg-editor
MIT License
42 stars 26 forks source link

[AWS] Handle 5 minute expiration on AWS S3 Policies #18

Closed brandonhub closed 5 years ago

brandonhub commented 6 years ago

Hello! We would like to implement image upload with the Froala editor and we've semi-successfully accomplished this by following this tutorial. However, we've run into a small snag. Image upload only seems to work within 5 minutes of initializing the Froala editor. Any uploads that are attempted after the 5 minutes have elapsed will fail with a <Code>AccessDenied</Code><Message>Invalid according to Policy: Policy expired.</Message> error message.

I suspect this behavior is due to this line, which seems to be hardcoded within the PHP sdk without the ability to customize it with a parameter or config of any sort.

Is there a way to handle this 5 min policy expiration or perhaps configure the timeout period from outside the php sdk? Thanks!

shreypasari-accolite commented 5 years ago

hi @stefanneculai I am not able to reproduce the error, can you help me it how to reproduce. Thanks

stefanneculai commented 5 years ago

@shreypasari-accolite sure:

mohit18513 commented 5 years ago

Hi @stefanneculai, is it manadatory to use same hash for subsequent uploads or is there way to generate new hash whenever image upload happens? Thanks Mohit

stefanneculai commented 5 years ago

To test https://github.com/froala/wysiwyg-editor-php-sdk/issues/18#issuecomment-466976967, yes you should be using the same hash.

mohit18513 commented 5 years ago

Thanks @stefanneculai. We are using private bucket and when we are generating hash (acl- private)using java and passing it to imageUploadToS3 attribute then image is getting uploaded on S3 and in response we are getting image url which is not accessible since bucket is private. Can you please help me to know what we need to with returned url to make it accressible?

Also we are using elixir in backend and we want to generate hash using elixir and somehow correct hash is not being generated due to which image does not get upload on S3. Can you please share some sample code of generating s3hash using elixir as well?

stefanneculai commented 5 years ago

@mohit18513 please make sure that you set the right CORS policy for your bucket. Also, you should make the images accessible to everyone (public) so that they can be accessed. Unfortunately, we're not familiar with Elixir in order to help more on it.

mohit18513 commented 5 years ago

@stefanneculai, our bucket is private and we can not make it public as we can not make images accessible to everyone. Can you please confirm that froala s3 image upload functionality works only with public bucket and it can not be used with private bucket?

drfraker commented 4 years ago

@mohit18513 Did you find a solution to the "private images" problem? I'm looking at this editor but it seems that images must be public in order for it to work.

mohit18513 commented 4 years ago

Hi, Yes, we had solved this problem. We had used imageUploadUrl attribue to upload image on s3. We had passed api url in imageUploadUrl and then in backend, we generated s3 presigned upload url and download url. Upload url is used to image on s3 private bucket. Once the image is uploaded on s3 then we returned the download url which is further used by froala editor to show image in editor. Please let me know if you have any questions. Thanks.

On Sat 25 Jan, 2020, 1:43 AM Dustin Fraker, notifications@github.com wrote:

@mohit18513 https://github.com/mohit18513 Did you find a solution to the "private images" problem? I'm looking at this editor but it seems that images must be public in order for it to work.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/froala/wysiwyg-editor-php-sdk/issues/18?email_source=notifications&email_token=AB5G7FQG4M7K6M3TSA36I7DQ7NDXDA5CNFSM4F3IZDKKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJ36RII#issuecomment-578283681, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB5G7FUQELULEOJP2EP3GRTQ7NDXDANCNFSM4F3IZDKA .