search

froala / wysiwyg-editor

The next generation Javascript WYSIWYG HTML Editor.
https://www.froala.com/wysiwyg-editor
Other
5.3k stars 673 forks source link

Truly remove jQuery #3830

Open robertvanhoesel opened 4 years ago

robertvanhoesel commented 4 years ago
Expected behavior.

Froala doens't need the ±30kb jQuery library and instead relies on vanilla js for simple dom manipulation. On multiple places is stated that jQuery is no longer needed.

Actual behavior.

jQuery is still being used, but right now it is duplicated inside of froala-editor.js (roughly 3000 lines), which is even worse. This has sevaral downsides:

Steps to reproduce the problem.

See size comparison below (froala v2 + jquery vs froala v3)

Froala 2 + jQuery Froala 3
image image
164kb inc plugins 139kb inc plugins
Editor version.

v3.0.1

Question

I understand that the current approach probably is already an improvement because you can selective include parts of jquery, however – this can be smaller. Is it on your roadmap to fully move away from jQuery or is this considered to be done? Also, is there any chance of moving to ES6 modules for better imports and tree shaking?

pleunv commented 3 years ago

Given the fact that jQuery removal was one of big bullet points of v3 I was honestly quite surprised to run into some, eh, familiar looking properties when digging through a Froala instance earlier. A little bit of transparency on this subject would've been nice. I honestly also don't like the idea of running an embedded (and outdated) version of jQuery that I have no control over whatsoever.

Based on other feedback requests I guess I already know the answer to my question, but any chance on an official response on this subject?

Thorry84 commented 3 years ago

Any chance we can get an update on this?

alexgurrola commented 1 year ago

It's fairly baked in with Froala 3, but it would be nice to have ES6 support for bundling and tree-shaking.

mrtronje commented 1 year ago

i don't think it's ok that we bought a product that doesn't deliver what is promised, if we read here https://froala.com/wysiwyg-editor/changelog/ that jquery is removed then it should be removed.

Thorry84 commented 1 year ago

Oh you bought Froala? I'm so sorry.

We've moved away from Froala, they kept getting more and more bugs and at one point they wouldn't even respond to our mails anymore. We paid a lot for their enterprise level support and we got treated like dirt because we had legitimate criticisms about their product.

And no, jQuery still isn't removed, they just made a stripped and broken version of jQuery and hardcoded that in. So the dependency is gone, but in the worst way.