froala / wysiwyg-rails

Ruby gem for Froala jQuery WYSIWYG HTML Rich Text Editor.
https://froala.com/wysiwyg-editor
MIT License
464 stars 101 forks source link

S3 Wrong URL formed which says CORS issue #108

Open aashishpsaini opened 3 years ago

aashishpsaini commented 3 years ago

In the recent amazon updates, there are a couple of changes in the AWS S3 API which is failing the S3 image upload in the editor. When we upload an image it throws an error saying Parsing failed with status as CORS error. As per the docs, the correct URL format is: https://<bucket-name>.s3.<region>.amazonaws.com

And the current URL formed is https://<region>.amazonaws.com/<bucket-name>

I had a look at the minified JS which computes this as: A.opts.imageUploadToS3 && (s = A.opts.imageUploadToS3.uploadURL ? A.opts.imageUploadToS3.uploadURL : "https://".concat(A.opts.imageUploadToS3.region, ".amazonaws.com/").concat(A.opts.imageUploadToS3.bucket)),

I believe this is a simple change and should be looked on a priority as things are breaking currently.

planetaska commented 1 year ago

For me the error is 400 bad request.

I have followed these instructions, but no luck. https://froala.com/wysiwyg-editor/docs/sdks/ruby/file-s3-upload/

The URL can be modified this way:

# in your controller or helper
hash = FroalaEditorSDK::S3.data_hash(options)
hash[:uploadURL] = 'https://your-bucket.s3.your-region.amazonaws.com/'
return hash

But still doesn't work - still got 400 bad request.

I guess the lib and the docs are both very outdated? Please update these issues. Thank you.