Enable support for Rails 7.1

froala / wysiwyg-rails

Ruby gem for Froala jQuery WYSIWYG HTML Rich Text Editor.

https://froala.com/wysiwyg-editor

MIT License

464 stars 101 forks source link

Enable support for Rails 7.1 #119

Closed justisb closed 6 months ago

justisb commented 8 months ago

Enables support for all Rails 7 minor releases by restricting dependency to below 8.0, which allows the gem to be installed on Rails 7.1, which was released two weeks ago.

This is inline with updates to support previous major Rails versions, which did not specify a minor release. Examples of previous wysiwyg-rails.gemspec changes after each release:

Bump for Rails 5: https://github.com/froala/wysiwyg-rails/commit/889336ee8d293fbd7f4afc8f2841538413396879
Bump for Rails 6: https://github.com/froala/wysiwyg-rails/commit/8b8c9eae1a60785e8acaad582cbc925023df1972
Original for Rails 4: https://github.com/froala/wysiwyg-rails/commit/0f713c929e37dee4360204909d2ae3c45712518

800a7b32 commented 8 months ago

:+1: for this please

800a7b32 commented 8 months ago

@justisb you'll also need to bump the version to 4.1.4 (https://github.com/Popmenu/wysiwyg-rails/blob/rails-7-1/lib/wysiwyg-rails/version.rb)

justisb commented 8 months ago

I believe they keep their version numbers in sync with the main Froala releases, e.g. https://froala.com/wysiwyg-editor/changelog/

justisb commented 7 months ago

@harasunu-narayan Any idea when we may be able to get this minor dependency update merged?

leedrum commented 6 months ago

@justisb I think we can close this PR. This one has been fixed in the commit https://github.com/froala/wysiwyg-rails/commit/87901ed4cb9ea6974c18bf44318b2372085e5d3a#diff-89e7d299629c1014d0f2ac27184582bc530fa6018fcb612faffe9e4489f4b292R17

justisb commented 6 months ago

Fixed by https://github.com/froala/wysiwyg-rails/commit/87901ed4cb9ea6974c18bf44318b2372085e5d3a#diff-89e7d299629c1014d0f2ac27184582bc530fa6018fcb612faffe9e4489f4b292R17.