search

froala / wysiwyg-rails

Ruby gem for Froala jQuery WYSIWYG HTML Rich Text Editor.
https://froala.com/wysiwyg-editor
MIT License
464 stars 102 forks source link

Move assets out of top-level to prevent conflicts #55

Open boatrite opened 6 years ago

boatrite commented 6 years ago

I ran into a problem when including wysiwyg-rails into our project. After adding the gem to our Gemfile and attempting to load a page, we were getting an error about an undefined sass variable.

The problem is that wysiwyg-rails adds themes/*.css to the asset precompilation array and our project also has a themes directory. But unlike froala's themes directory ours has partials that can't be compiled by themselves, so we'd get a sass error when trying to view any page.

Unfortunately, this is a breaking change. Not sure if there's a better way to go about this. Feedback very much welcome.

Cheers

stefanneculai commented 5 years ago

It's a good change, however, that would break all the current implementations. We might consider adding it in 2.9.0 release. Nice work.