search

froala / wysiwyg-rails

Ruby gem for Froala jQuery WYSIWYG HTML Rich Text Editor.
https://froala.com/wysiwyg-editor
MIT License
464 stars 102 forks source link

Remove Font Awesome as a hard requirement #65

Closed brendon closed 5 years ago

brendon commented 6 years ago

My only concern is the require statement in the engine. I'm not sure if it's needed, or perhaps the documentation could be updated to require users add this elsewhere. Rails should be loading the gem anyway without this.

Closes #64

kreintjes commented 6 years ago

@stefanneculai would be great to see this reviewed and merged to master! Would be glad to try it if the fork is updated to Froala 2.8.4 (https://github.com/froala/wysiwyg-rails/issues/64#issuecomment-401363740).

kreintjes commented 6 years ago

@stefanneculai I can confirm Brendon's changes are working in combination with the font-awesome-rails gem instead of font-awesome-sass. Did not try it with font-awesome-sass (which is the default advised gem), so might be word to give that a shot as well (is a bit difficult in my project since we are already using font-awesome-rails). Anyway, would be nice to see this merged and released.

@brendon thanks for the update!

brendon commented 6 years ago

Thanks @kreintjes :) It should work well no matter which way font awesome is bought into the project.