search

froala / wysiwyg-rails

Ruby gem for Froala jQuery WYSIWYG HTML Rich Text Editor.
https://froala.com/wysiwyg-editor
MIT License
464 stars 101 forks source link

Remove asset precompile config initializer #81

Open javierjulio opened 5 years ago

javierjulio commented 5 years ago

This is unnecessary as an asset gem. As shown in the docs for wysiwyg-rails gem, these files are required in manifest files that are already part of a Rails applications' precompile config. There is no need to also precompile these files too which causes a very large amount of files being generated when running rails assets:precompile (an extra file for each due to GZ).

I'm able to update or include any other changes that are necessary, just let me know. Happy to help. This resolves #56 which should be reopened. Update: created a new issue in #83.

Fixes #83

javierjulio commented 5 years ago

UPDATE: tests now passing

There is only one build failure: Ruby 1.9.3 where it can't seem to find a download. It seems this version isn't available. This is affecting all builds for awhile now. Note there are several release commits in master with the same failed builds.

$ rvm use 1.9.3 --install --binary --fuzzy
curl: (22) The requested URL returned error: 404 Not Found
Required ruby-1.9.3 is not installed - installing.
curl: (22) The requested URL returned error: 404 Not Found
Searching for binary rubies, this might take some time.
Requested binary installation but no rubies are available to download, consider skipping --binary flag.
Gemset '' does not exist, 'rvm ruby-1.9.3 do rvm gemset create ' first, or append '--create'.
The command "rvm use 1.9.3 --install --binary --fuzzy" failed and exited with 2 during .
javierjulio commented 4 years ago

Rebased. All tests are now passing.