search

frodsan / qunit-rails

[unmantained] QUnit JavaScript Testing on Rails
The Unlicense
51 stars 26 forks source link

Foundation javascripts cause it to throw lots of errors #15

Closed jakecraige closed 10 years ago

jakecraige commented 10 years ago

When i have by #= require foundation in my application.js.coffee file it attempts fails loading the first file with this error Uncaught TypeError: Layer must be a document node and then the rest throw errors because foundation wasn't defined

elsurudo commented 10 years ago

I am having the same issue. Have you found a workaround, by any chance?

jakecraige commented 10 years ago

Sadly no.. I just has to not include foundation in my tests

On Thursday, January 9, 2014, Ernest Surudo wrote:

I am having the same issue. Have you found a workaround, by any chance?

— Reply to this email directly or view it on GitHubhttps://github.com/frodsan/qunit-rails/issues/15#issuecomment-31920135 .

See my vizify bio! [image: James Craige's Visual Thumbprint]https://www.vizify.com/es/501a695db146e100020002bd

elsurudo commented 10 years ago

Darn. I'm trying to do some integration testing with Ember.js and QUnit, so I need to include Foundation to have my whole app working...

frodsan commented 10 years ago

Could you provide a test app to reproduce this?

jakecraige commented 10 years ago

here's one https://github.com/jakecraige/foundation-qunit-failure-example

It's just a base app with foundation and qunit-rails setup and throws the errors referenced above

elsurudo commented 10 years ago

Nice, beat me to the punch :)

On Jan 20, 2014, at 2:36 AM, Jake Craige notifications@github.com wrote:

here's one https://github.com/jakecraige/foundation-qunit-failure-example

— Reply to this email directly or view it on GitHub.

frodsan commented 10 years ago

I released 0.0.6, could you test it please? :smile:

jakecraige commented 10 years ago

That fixed it. Nice job! I wonder what it was. Looks like foundation was updated as well recently.

Either way, with the newest of both no more errors

frodsan commented 10 years ago

TBH, I think it was a problem in foundation. I didn't do anything :p. Anyway, I'm glad that it's fixed now :).

elsurudo commented 10 years ago

Beautiful, just upgraded foundation-rails, and works for me too :)

On Jan 20, 2014, at 7:13 PM, Francesco Rodríguez notifications@github.com wrote:

TBH, I think it was a problem in foundation. I didn't do anything :p. Anyway, I'm glad that it's fixed now :).

— Reply to this email directly or view it on GitHub.