search

froemken / repair_translation

Get rid of displaying the default file in translated records of extbase extensions
25 stars 9 forks source link

sorting #5

Closed HorstBaumann closed 6 years ago

HorstBaumann commented 6 years ago

great extension ! But there is one small bug: it ignores the sorting of the files. I fixed it by adding sorting_foreign to the query in /repair_translation/Classes/SignalSlot/Repair.php :

original: $rows = $this->getDatabaseConnection()->exec_SELECTgetRows( '*', 'sys_file_reference', implode(' AND ', $where) );

new: $rows = $this->getDatabaseConnection()->exec_SELECTgetRows( '*', 'sys_file_reference', implode(' AND ', $where), '', 'sorting_foreign' );

froemken commented 6 years ago

Hello @HorstBaumann

Thank you for your hint. It is already solved at master, but I have never pushed it to TER. I have just released version 1.1.0 which should be available within the next 15 Minutes at TER and Packagist.

Please test that version and give me feedback if you want.

Stefan

HorstBaumann commented 6 years ago

It works fine :-) Thanks for updating this great extension !!! (it's a shame, that it is still necessary and the core-bug still exists...)