search

frog23 / TomScottMap

A unofficial map of the videos created by Tom Scott. See his Youtube channel for the complete list of videos (including those that are not geo-referenceable).
https://www.frog23.net/TomScottMap/
61 stars 19 forks source link

Styling suggestion with Skeleton #43

Closed Max-le closed 2 years ago

Max-le commented 2 years ago

Hi frog23,

Hereby I propose to use the css framework Skeleton for a slight improvement of design.

So I added skeleton.css, linked it to index.html and review.html, and removed the Helvetica font on tsm.css to apply Skeleton's font. Finally I changed the a tag's color to red.

See the two screenshots below for an overview.

Screenshot 2022-06-08 at 19 04 40 Screenshot 2022-06-08 at 19 04 35

.

Let me know if you like it !

Plushb9rry commented 2 years ago

That looks awesome, i was also trying to improve the page few days ago, but I didn't complete it well.

image

Plushb9rry commented 2 years ago

So I added skeleton.css, linked it to index.html and review.html, and removed the Helvetica font on tsm.css to apply Skeleton's font. Finally I changed the a tag's color to red.

These fonts look a lot familiar to 'Railway' by google

Max-le commented 2 years ago

Thanks, your idea looks cool as well ( and yes, you recognized the font correctly ) :)

frog23 commented 2 years ago

Hey Max-le, thank you for your PR. The site looks a lot better now. Sorry, that it took me so long to respond. It has been a busy couple of weeks and I didn't have time to properly review the PR. Thanks again and sorry for the wait. Cheers, Frog23

Plushb9rry commented 2 years ago

also, which of these look good?

image image

Max-le commented 2 years ago

I prefer the first one, with his face ! 🙂

frog23 commented 2 years ago

I added my thoughts on the matter here: https://github.com/frog23/TomScottMap/pull/50#issuecomment-1179729938