search

froger-me / wp-packages-update-server

WP Packages Update Server - Run Your Own Update Server for Plugins and Themes
GNU General Public License v3.0
141 stars 39 forks source link

Uncaught ReferenceError: Wppus is not defined #39

Closed ElementMedia closed 9 months ago

ElementMedia commented 9 months ago

I get a Uncaught ReferenceError: Wppus is not defined error when I try and click the "Get remote package" button from the "Prime a package using a Remote Repository (recommended)" option.

Maybe related: When on the Licenses tab I click on "Add License", nothing happens.

froger-me commented 9 months ago

Hi, thank you for the heads up, it will be fixed ASAP! It seems you are using code from the master branch. So far none of the 2.x version has been released: for stable (but soon-to-be incompatible) version, please see https://github.com/froger-me/wp-packages-update-server/releases

Thanks again for the heads up, it's now in the bakcklog!

ElementMedia commented 9 months ago

Thanks for your quick response. I was indeed using the master branch, since the version I used earlier was missing the wppus_get_package_info or wppus_download_local_package function (that was available in the docs).

I'll try the 1.14.16 release.

You stated that version 2 and onward are not compatible with the current releases. That doesn't mean that we can't update/migrate to a newer version?

froger-me commented 9 months ago

There has not been significant updates (aside from contribution 8.2 compat) to this project for close to 4 years. During the past month, I have:

  1. merged contributions to ensure we have a stable v1.x compatible with current latest PHP ; a branch will be created upon release of v2 and will accept contribution for maintenance
  2. started a v2.x with no upgrade path, given the amount of changes, respecting semver.

Upgrading from v1 to v2 should not be too painful - swapping package update library, existing licenses should still be working, although there may be a database column to add ; other than than it's mostly it's option names that differ, and a lot of new added features, so it's a matter of reinstalling and reconfiguring. But as always, it's worth testing in a staging env before rolling out any critical system in prod.

If time allows (currently writing a WooCommerce integration leveraging all the new APIs), I'll write an upgrade path ; it will still be manual though, not an automatic migration.

froger-me commented 9 months ago

Note regarding the errors you found: if you want to speed up the release of 2.x, I very much welcome pull requests :D (provided WP coding standards are fully respected, code formatting and variable naming semantic consistency is preserved, etc etc)

froger-me commented 9 months ago

fixed in e8754e8