search

frogermcs / AndroidDevMetrics

Performance metrics library for Android development (includes dagger2metrics)
1.54k stars 118 forks source link

Don't work in with dagger2 written by kotlin #23

Open ghost opened 8 years ago

ghost commented 8 years ago

Hi, I find that this don't work when dagger2 written by kotlin. Is it a bug? Or my problems?

williamwebb commented 8 years ago

Can you provide an example project? Or the error you are seeing?

ghost commented 8 years ago

https://github.com/zengzhihao/CNodeClient Above is my project, when I install apk, dagger2 shows no data. It works before I modify di's impl from java to kotlin.

williamwebb commented 8 years ago

Ah OK now i understand. This comes from the way the plugin works. But basically what is happening is the kotlin generates files are not generates at the time the plugin runs, so it doesn't make the modifications it needs to make. I would suggest opening up another issue for the plugin to support the new transform API. Using the transform API will fix this issue and bring the plugin more inline with official standards.

In the new issue please reference this one.

lenguyenthanh commented 8 years ago

How is it going? I face this problem too :( I doesn't work for activity metrics too. It shows: device-2016-05-12-143307

A-Zaiats commented 7 years ago

Kotlin has some problem with AOP. It is a known problem now. And thi plugin can helps.

kuhnroyal commented 7 years ago

I am interested in this, what is needed to make this work?

gallal commented 7 years ago

Hey - are there any plans to make this compatible with Koltin or will this issue be closed as a no-fix?