search

froi / add_invite_user

GitHub Action to invite user into a GitHub Organization.
MIT License
0 stars 0 forks source link

Refactoring the parser file to take in the email domain regex as well… #17

Closed Chocrates closed 4 years ago

Chocrates commented 4 years ago

…, failing action if the email is invalid, adding tests for the above

Changes for the first part of issue #9, will handle validating the user that created the issue in another PR/branch

Chocrates commented 4 years ago

I ended up basing the user created validation on this branch and just merged the changes into this PR since it was still open.

Chocrates commented 4 years ago

Hey @froi, I was thinking that the trusted user was the only user that we would accept user creation issues from. For instance, the user would be a trusted bot that would open the issues.
The users in the ticket would still be validated against the email domain in all cases.

froi commented 4 years ago

Gotcha. Then some of my comments are not going to be accurate. I think I got confused with the function naming and just puked on my self 😝

My comments on what to do if something fails are still valid I think. Thoughts?

Thanks for clearing it up.

Chocrates commented 4 years ago

Yeah, I think most of them were still valid changes. Going through them again now and will accept most of 'em.

Chocrates commented 4 years ago

Ready for review again

Chocrates commented 4 years ago

Bah! I forgot to setup my gpg keys! I'll get that fixed tonight. Prolly have to re-review :(

Chocrates commented 4 years ago

@froi, I rebased and got the commits signed and then force pushed. Will need a re-review :/