froi / add_invite_user

GitHub Action to invite user into a GitHub Organization.
MIT License
0 stars 0 forks source link

[BUG] - Issue will still run through success path when a non rate limit error happens #29

Closed Chocrates closed 4 years ago

Chocrates commented 4 years ago

https://github.com/froi/add_invite_user/blob/master/src/main.js#L126

Looks like after the issue gets the error comment, it will fall out of the catch block and continue executing the success steps.

I think we need to add the throw clause like is done in the rate limit section https://github.com/froi/add_invite_user/blob/master/src/main.js#L109

It was missed in the unit tests, and I am unsure how to trigger this type of error in integration tests 😭