search

froi / add_invite_user

GitHub Action to invite user into a GitHub Organization.
MIT License
0 stars 0 forks source link

feat(emailRegex): case insensitive #31

Closed jasonmacgowan closed 4 years ago

jasonmacgowan commented 4 years ago

email validation regex shouldn't be case sensitive by default

jasonmacgowan commented 4 years ago

@Chocrates tests are failing against master as well, do you know what's up with that?

Chocrates commented 4 years ago

try npm install --force https://github.com/Chocrates/octomock.git
The addLabels function may be new to the mocking library.
Do you know of a better way to package it so npm can grab updates?

jasonmacgowan commented 4 years ago

@Chocrates that worked, I'm blowing up my node_modules package-lock.json and will add that commit

Chocrates commented 4 years ago

node_modules isn't in this repo, I don't know why the tests failed actually... I need to read up on package-lock perhaps

jasonmacgowan commented 4 years ago

I think if my node_modules already has the reference to the octokit it won't update it, and I was afraid my package-lock.json would have an older version referenced. all is good now.