search

frol / bos-component-ts-starter

TypeScript project starter for NEAR BOS
https://near.org/frol.near/widget/bos-component-ts-starter.components.pages.homepage
MIT License
10 stars 3 forks source link

Move npm to pnpm #13

Closed gojimotoro closed 5 months ago

gojimotoro commented 5 months ago

Move npm to pnpm to improve packages installation speed and reduce the size of node_modules

Added typescript to dev dependencies

frol commented 5 months ago

@gojimotoro thank you for the contribution. Can you demonstrate a successful CI run so we can see the performance gains?

gojimotoro commented 5 months ago

@frol never liked GitHub actions, but needed to learn them 😆

Fixed

frol commented 5 months ago

I thought that the gains are on the CI side, but it turned out that adding pnpm only slows CI down:

Before (10 seconds): https://github.com/frol/bos-component-ts-starter/actions/runs/9245554998/job/25469633851

After (16 seconds): https://github.com/frol/bos-component-ts-starter/actions/runs/9373833697/job/25808483426

It is trivial to skilled frontend engineers to switch commands from npm to pnpm or yarn, so I don't see much value in changing the default and usually automatically installed npm with tools that require additional installation, which might confuse less experienced developers.