search

frolfr / frolfr-server

Frolfr's Rails API
http://frolfr.herokuapp.com
5 stars 1 forks source link

User Stat Log #135

Closed gschorkopf closed 9 years ago

gschorkopf commented 9 years ago

Adds a bunch of stats to the user profile page

Had to kinda overwrite the serializer's initialize method... apparently you can't pass a serializer additional parameters (we need the user AND current user for most of these stats)... If anyone has an elegant solution for this, I'd love input.

@killpack @pdougall1 @ksenna

135

coveralls commented 9 years ago

Coverage Status

Coverage decreased (-1.49%) to 90.75% when pulling da0b9d8f967fe866c9140b92f12262abbf257c5f on stats into 656df5b92b4bf14c67e5402c562c9fe0f78367c4 on master.

coveralls commented 9 years ago

Coverage Status

Coverage decreased (-1.49%) to 90.75% when pulling de54f3a64161a833352b4b305f2db36d77060e18 on stats into 656df5b92b4bf14c67e5402c562c9fe0f78367c4 on master.

pdougall1 commented 9 years ago

@gschorkopf I might just be blind but I can't find where you overwrote the initialize in a serializer?

I think it looks good myself.

gschorkopf commented 9 years ago

We took it out! Turned out it was totally unneeded. On Feb 3, 2015 9:25 PM, "Patrick Dougall" notifications@github.com wrote:

@gschorkopf https://github.com/gschorkopf I might just be blind but I can't find where you overwrote the initialize in a serializer?

I think it looks good myself.

— Reply to this email directly or view it on GitHub https://github.com/gschorkopf/frolfr/pull/135#issuecomment-72778807.

pdougall1 commented 9 years ago

ah sweet

:+1: