Feat/adding custom label and dimensions names

frolicorg / frolic-react

React Component Library to Build Analytics Dashboard 10x Faster

https://www.frolicorg.com/frolic-react/docs

Apache License 2.0

64 stars 3 forks source link

Feat/adding custom label and dimensions names #4

Open Tabhi109 opened 1 year ago

Tabhi109 commented 1 year ago

added types labelNames and dimensionsNames in the interface ChartInterface
added Tooltip for viewing the custom Label & Dimension Names.
ran it on storybook

arihantparsoya commented 1 year ago

We need it for all the charts which has X and Y Axis.

arihantparsoya commented 1 year ago

Refer to recharts documentation https://recharts.org/en-US/api/YAxis#label

Tabhi109 commented 1 year ago

Okay got it !

Tabhi109 commented 1 year ago

added names functionality in all the charts with x and y axis

arihantparsoya commented 1 year ago

Can you explain why you have decided to use Tooltip for Axis labels?

Axis labels can be defined inside the axis tags themselves: https://recharts.org/en-US/api/YAxis#label

Tabhi109 commented 1 year ago

@arihantparsoya I added the names using the ToolTip component so that It will be more interactive for users as well as a Cleaner UI will be maintained when there will be a large set of data, but as you want this to be in Axis itself, I will work on it!

arihantparsoya commented 1 year ago

Yes, the the axis is the main thing, user should be able to know the axis without using the tooltips.

Can you share a screenshot of the tooltip after your modified code?

I would suggest keep the tooltip changes in separate branch and focus only on the axis for not. because tooltip is defined in other locations as well.