Do not shim inside `.node.ts` files

fromdeno / deno2node

Compile your Deno project to run on Node.js.

MIT License

115 stars 3 forks source link

Do not shim inside `.node.ts` files #16

Closed KnorpelSenf closed 2 years ago

KnorpelSenf commented 2 years ago

Currently, the tool adds shims to files that are specific to Node.

The point of shims is to make Deno code run on Node. However, in platform-specific files, this does not make sense, because the code doesn't even run on Deno.

This behaviour is confusing, as https://github.com/grammyjs/grammY/pull/80#discussion_r744538518 shows.

KnorpelSenf commented 2 years ago

How can something be both breaking and a bug? https://xkcd.com/1172/