search

frondeus / fvtt-syrin-control

Syrinscape Online Control plugin for FoundryVTT
MIT License
13 stars 4 forks source link

Support FoundryVTT v12 #118

Closed chrispickford closed 1 month ago

chrispickford commented 3 months ago

Is your feature request related to a problem? Please describe. FoundryVTT has now released stable v12 (Build 324) but this module only supports v11.

Describe the solution you'd like Please update this module to support v12.

Additional context FoundryVTT v12 release notes: https://foundryvtt.com/releases/12.324

chillman0122 commented 3 months ago

FWIW I'm not getting any sound out of Syrin control after the v12 update.

Morfedel commented 2 months ago

neither have I; I know new updates break things, but still, a little frustrtating. Anyone know if they are paying attention to this?

roi007leaf commented 2 months ago

Doesn't look like there has been an update for a while, just use Kenkufm and discord

frondeus commented 2 months ago

Sorry, I decided to stop maintaining this project. I updated the README.

alessiocali commented 2 months ago

If it's of any help, I believe updating getAudioContext to getAnalyzerContext in game.ts should suffice to support V12. At least that's what I see from a quick and dirty experiment. I would issue a pull request but I don't have a suitable environment set up yet, I'd need to spend some time getting that running (and educate myself in some concepts I'm not familiar with)

scooper4711 commented 2 months ago

Someone should suggest this plugin to https://github.com/League-of-Foundry-Developers to see if someone else wants to maintain it.

chillman0122 commented 2 months ago

Someone should suggest this plugin to https://github.com/League-of-Foundry-Developers to see if someone else wants to maintain it.

Done, comment is here https://github.com/orgs/League-of-Foundry-Developers/discussions/7#discussion-6863684

alessiocali commented 1 month ago

Proposed a possible fix in #119