notrealdan
commented
1 year ago That link should probably instead just not have the "modules" folder in the path. This link does work for me instead: https://[redacted]:30000/ui/parchment.jpg
Closed notrealdan closed 1 year ago
notrealdan
commented
1 year ago That link should probably instead just not have the "modules" folder in the path. This link does work for me instead: https://[redacted]:30000/ui/parchment.jpg
frondeus
commented
1 year ago Hi! Thank you for both reports and very clear issue descriptions, stating exactly what's wrong. It made my coding life much, much easier; I appreciate it :)
Anyway, I am not sure why I didn't catch it locally before; perhaps it's because I'm running it with the URL:
https://localhost:9443/game and therefore, ../ui/parchment in the CSS worked?
I am still trying to figure out how I missed it.
Nevertheless now it's fixed: https://github.com/frondeus/fvtt-syrin-control/commit/1eb57052f770172fcef3e9a74600bc3a4952a9e4
I am going to release it soon. Just let me do one more manual test of the whole module :)
notrealdan
commented
1 year ago That fixed it, thanks!
I have one request, if possible. It looks like the new UI improvement isn't compatible with the module Monk's Sound Enhancements. It's not completely broken. It's very minor, actually. That module adds tabs to the Edit Playlist box, and that pushes the rest of the content down, but the box doesn't resize to account for this. It also adds some additional options that go away when Syrincontrol is present. Here are some screenshots to demonstrate.
Only Syrincontrol:
Only Monk's Sound Enhancements:
Both modules:
"No" is an acceptable answer for this one, but hopefully it's also an easy adjustment. :)
notrealdan
commented
1 year ago I'll clarify that the dialog box sizing is the issue, since the additional options the other module adds aren't really relevant to Syrincontrol playlists anyways, so they're not missed there.
frondeus
commented
1 year ago I created separate issue for that. Closing this one
![https://[redacted]:30000/ui/parchment.jpg](https://[redacted]:30000/ui/parchment.jpg){kind=link}
Describe the bug
There seems to be an issue with the Edit Playlists dialog. It's hard to see the text fields and buttons, and doesn't match the screenshots in the release notes for "0.4.1 - polished UI."
To Reproduce
Expected behavior
We should be able to read everything, but can't.
Screenshots
Details
OS: Client is Window 10, Server is Linux Mint 21.1 running Foundry on NodeJS 18.15.0 Browser: Chrome Foundry VTT v10.291 Module version: 0.4.2 [No, same result] Does it work in Safety Mode (without other plugins enabled) [Yes] I did read FAQ - https://github.com/frondeus/fvtt-syrin-control/wiki/Frequently-Asked-Questions
Logs
Additional context
I redacted my hostname from the Foundry URL in the logs, but you can see a 404 error when opening the Edit Playlist dialog. That would seem to be the issue. That path does not exist on my instance.